chore: remove multiorg phase2 feat flag #6643
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdoconnell
commented
Mar 3, 2023
| <hr className="account-settings--divider" /> | ||
| <LeaveOrgButton /> | ||
| </> | ||
| )} | ||
| {shouldShowDeleteFreeAccountButton && <DeleteFreeAccountButton />} |
There was a problem hiding this comment.
The "Leave Org" button was only here for backwards compatibility for situations where the feature flag was turned off. It now lives on the org settings page.
wdoconnell
commented
Mar 3, 2023
| @@ -35,7 +37,7 @@ const AccountTabs: FC<Props> = ({activeTab}) => { | |||
| }, | |||
| { | |||
| id: 'organizations', | |||
| enabled: isFlagEnabled('createDeleteOrgs'), | |||
| enabled: CLOUD, | |||
| link: `/orgs/${orgID}/accounts/orglist`, | |||
There was a problem hiding this comment.
The organization tab cannot be accessed from OSS, where there is no multi-org or access to quartz APIs.
wdoconnell
commented
Mar 3, 2023
| name: 'Settings', | ||
| iconFont: IconFont.CogSolid_New, | ||
| href: `/orgs/${activeOrg.id}/accounts/settings`, | ||
| }, |
There was a problem hiding this comment.
There's no need for the 'enabled' distinction here, as all of these tabs are accessible without condition. The global header only exists in cloud, so there's no need for a CLOUD guard either.
wdoconnell
commented
Mar 3, 2023
| @@ -175,7 +171,7 @@ const OrgProfileTab: FC = () => { | |||
| stretchToFitWidth={true} | |||
| > | |||
| <> | |||
| {allowSelfRemoval && showLeaveOrgButton && <LeaveOrgButton />} | |||
There was a problem hiding this comment.
This is already subordinate to a CLOUD check, so we don't need another one.
wdoconnell
force-pushed
the
remove_createdelete_flag
branch
from
de8851d
to
61acac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5243
Removes the feature flag associated with multiorg phase two (creating and deleting orgs). After this PR, the flag still needs to be removed from IDPE, and then configcat.
Checklist
Authors and Reviewer(s), please verify the following: